Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ConfigurableDataSource data generators for Classification #162

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Adds ConfigurableDataSource data generators for Classification #162

merged 1 commit into from
Aug 20, 2021

Conversation

Craigacp
Copy link
Member

Description

Adds 5 data generators for 2d binary classification problems suitable for classification demos & tutorials.

They are modelled on earlier Tribuo demo datasets but updated for the current API.

Motivation

See #160 for motivation.

@Craigacp Craigacp added the Oracle employee This PR is from an Oracle employee label Aug 19, 2021
jhalexand
jhalexand approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@jhalexand jhalexand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Math all looks right to me, though I didn't actually generate any of the data sets in reviewing this.

@jhalexand jhalexand merged commit 9d834e2 into main Aug 20, 2021
@Craigacp Craigacp deleted the classification-data-source branch August 21, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhalexand jhalexand jhalexand approved these changes

Assignees
No one assigned
Labels
Oracle employee This PR is from an Oracle employee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Craigacp @jhalexand